Add default resource state for SqlVulnerabilityAssessmentsSetting #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resource cannot be deleted or created as it has the same lifecycle as the SQL Server resource. - Set the default state back to what is observed when the resource is first created.
danielrbradley
approved these changes
Feb 10, 2025
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3941 +/- ##
=======================================
Coverage 57.02% 57.03%
=======================================
Files 79 79
Lines 12548 12548
=======================================
+ Hits 7156 7157 +1
+ Misses 4841 4840 -1
Partials 551 551 ☔ View full report in Codecov by Sentry. |
thomas11
deleted the
tkappler/JasonWhall/SqlVulnerabilityAssessmentsSetting
branch
|
This PR has been shipped in release v2.87.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3934
Set default state for Vulnerability Assessment Setting to allow resource to be managed using Pulumi.
This PR recreates #3935 so the CI tests can run.